Skip to content

Conversation

siegfriedweber
Copy link
Member

Description

Remove the Merge implementation for PodTemplateSpec

It was broken because the instance was overriden by the given defaults.

This function is not used by the Stackable operators. Even if it is used by other operators, it is better to remove it than to "silently" switch the parameters.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@siegfriedweber siegfriedweber self-assigned this Sep 3, 2025
@siegfriedweber siegfriedweber requested a review from a team September 3, 2025 08:26
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Sep 3, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 3, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code removed is always good 👍

@siegfriedweber siegfriedweber added this pull request to the merge queue Sep 3, 2025
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Sep 3, 2025
Merged via the queue into main with commit 4bd0ff4 Sep 3, 2025
8 checks passed
@siegfriedweber siegfriedweber deleted the feat/remove-impl-merge-for-podtemplatespec branch September 3, 2025 08:44
Techassi pushed a commit that referenced this pull request Sep 4, 2025
* feat: Remove the Merge implementation for PodTemplateSpec

* chore: Remove unused imports
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants