refactor(stackable-versioned): Introduce idents for fields/variants #1088
+172
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techassi
force-pushed
the
refactor/stackable-versioned-item-idents
branch
from
d52da8e to
ab67c21
Compare
Techassi
force-pushed
the
refactor/stackable-versioned-item-idents
branch
from
ab67c21 to
f5d0ce9
Compare
NickLarsenNZ
reviewed
Sep 8, 2025
NickLarsenNZ
previously approved these changes
Sep 8, 2025
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Co-authored-by: Nick <[email protected]>
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/secret-operator#627 and stackabletech/secret-operator#634.
This PR finally moves all variant and field idents into a single place instead of formatting the same idents at multiple different places. This is in preparation to support nested tracking in enums, which is needed for the SecretClass.