Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 8, 2025

Description

https://github.com/kube-rs/kube/releases/tag/2.0.0
https://graham.cool/schemars/migrating/

During the bump I noticed a regression in kube 2.0.0 and created kube-rs/kube#1821.
However, we can easily work around this but removing a single rustdoc comment, which didn't show up in the CRD in the first place. It's in crates/stackable-operator/src/product_logging/spec.rs.

I tested this change by bumping op-rs in zookeeper-operator and smoke tests passed.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this Sep 8, 2025
@sbernauer sbernauer requested a review from a team September 8, 2025 14:18
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Sep 8, 2025
@Techassi Techassi self-requested a review September 8, 2025 14:43
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Track in Stackable Engineering Sep 9, 2025
@sbernauer sbernauer moved this from Development: Track to Development: Waiting for Review in Stackable Engineering Sep 18, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 18, 2025
@sbernauer sbernauer added this pull request to the merge queue Sep 19, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 19, 2025
Merged via the queue into main with commit 9b8ea36 Sep 19, 2025
8 checks passed
@sbernauer sbernauer deleted the chore/kube-2.0.0 branch September 19, 2025 08:47
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants