Skip to content

Conversation

sbernauer
Copy link
Member

Description

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this Sep 23, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Sep 23, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 23, 2025
@sbernauer sbernauer added this pull request to the merge queue Sep 23, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 23, 2025
Merged via the queue into main with commit 0dc40bc Sep 23, 2025
8 checks passed
@sbernauer sbernauer deleted the chore/product-config-0.8.0 branch September 23, 2025 12:42
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants