-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat!: Add new ListenerClass.stickyNodePorts
field
#1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,5 +66,19 @@ pub mod versioned { | |
/// Defaults to `HostnameConservative`. | ||
#[serde(default = "ListenerClassSpec::default_preferred_address_type")] | ||
pub preferred_address_type: core_v1alpha1::PreferredAddressType, | ||
|
||
/// Wether a Pod exposed using a NodePort should be pinned to a specific Kubernetes node. | ||
/// | ||
/// By pinning the Pod to a specific (stable) Kubernetes node, stable addresses can be | ||
/// provided using NodePorts. The stickiness is achieved by listener-operator by setting the | ||
/// `volume.kubernetes.io/selected-node` annotation on the Listener PVC. | ||
/// | ||
/// However, this only works on setups with long-living nodes. If your nodes are rotated on | ||
/// a regular basis, the Pods previously running on a removed node will be stuck in Pending | ||
/// until you delete the PVC with the stickiness. | ||
Comment on lines
+76
to
+78
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: Could we somehow detect this and automatically remove the stickiness? Or is that something we don't want? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally we have auto-detection in listener-op, which detects what ListenerClasses it should create, based on detecting GKE/AKS/IONOS etc. You might recall this from the CRD maintainer discussions. |
||
/// | ||
/// Because of this we don't enable stickiness by default to support all environments. | ||
#[serde(default)] | ||
pub sticky_node_ports: bool, | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.