-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat(stackable-operator): Support gitsync via SSH #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adwk67
wants to merge
7
commits into
main
Choose a base branch
from
feat/gitsync-ssh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
sbernauer
reviewed
Dec 4, 2025
Techassi
reviewed
Dec 4, 2025
Comment on lines
+70
to
+71
| /// The referenced Secret must include two fields: `key` and `knownHosts`. | ||
| /// This cannot be provided if `credentials_secret` is also provided. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: Ideally we want this to be a single field instead which is an enum with two variants. This completely prevents the potential misuse by users.
I know this is a breaking change, but we should consider it going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite for stackabletech/airflow-operator#382.
Tested with stackabletech/airflow-operator#718.
The gitsync test in Nifi was also successfully tested with this PR.
CRD Change
Previously the optional
credentialsSecretwas used for username & password/token:It is now possible to also connect via ssh using
sshSecret:i.e. the optional field
sshSecrethas been added. EithercredentialsSecretorsshSecretcan be specified, but not both (an exception is thrown if this is detected).Alternatives considered
accessSecret, holding eithercredentialsSecretorsshSecret, holding either types of secretIn both cases the change is breaking and/or the naming is unhelpful and the usage is slightly different from what is documented by gitsync itself.
Definition of Done Checklist
Author
Reviewer
Acceptance