Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/stackable-webhook/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed

- Don't error in case the `initial_reconcile` Receiver is dropped ([#1133]).

[#1133]: https://github.com/stackabletech/operator-rs/pull/1133

## [0.8.0] - 2025-12-32

### Added
Expand Down
12 changes: 4 additions & 8 deletions crates/stackable-webhook/src/webhooks/conversion_webhook.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use kube::{
Api, Client, ResourceExt,
api::{Patch, PatchParams},
};
use snafu::{ResultExt, Snafu, ensure};
use snafu::{ResultExt, Snafu};
use tokio::sync::oneshot;
use tracing::instrument;

Expand All @@ -27,9 +27,6 @@ use crate::WebhookServerOptions;

#[derive(Debug, Snafu)]
pub enum ConversionWebhookError {
#[snafu(display("failed to send initial CRD reconcile heartbeat"))]
SendInitialReconcileHeartbeat,

#[snafu(display("failed to patch CRD {crd_name:?}"))]
PatchCrd {
source: kube::Error,
Expand Down Expand Up @@ -262,10 +259,9 @@ where
// After the reconciliation of the CRDs, the initial reconcile heartbeat is sent out
// via the oneshot channel.
if let Some(initial_reconcile_tx) = self.initial_reconcile_tx.take() {
ensure!(
initial_reconcile_tx.send(()).is_ok(),
SendInitialReconcileHeartbeatSnafu
);
// This call will (only) error in case the receiver is dropped, so we need to ignore
// failures.
let _ = initial_reconcile_tx.send(());
}

Ok(())
Expand Down
Loading