-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Add StatefulSet rollout tracker #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
//! Tools for managing rollouts of Pod controllers (such as [`StatefulSet`]). | ||
|
||
use std::borrow::Cow; | ||
|
||
use k8s_openapi::api::apps::v1::StatefulSet; | ||
use snafu::Snafu; | ||
|
||
/// The reason for why a [`StatefulSet`] is still rolling out. Returned by [`check_statefulset_rollout_complete`]. | ||
#[derive(Debug, Snafu)] | ||
#[snafu(module(outdated_statefulset))] | ||
pub enum StatefulSetRolloutInProgress { | ||
/// Indicates that the latest version of the [`StatefulSet`] has not yet been observed by Kubernetes' StatefulSet controller. | ||
/// | ||
/// Kubernetes' controllers run asynchronously in the background, so this is expected when the `spec` has just been modified. | ||
#[snafu(display("generation {current_generation:?} not yet observed by statefulset controller, last seen was {observed_generation:?}"))] | ||
NotYetObserved { | ||
current_generation: Option<i64>, | ||
observed_generation: Option<i64>, | ||
}, | ||
|
||
/// Indicates that outdated replicas still exist. | ||
#[snafu(display("only {updated_replicas} out of {total_replicas} are updated"))] | ||
HasOutdatedReplicas { | ||
total_replicas: i32, | ||
updated_replicas: i32, | ||
}, | ||
} | ||
|
||
/// Checks whether all ReplicaSet replicas are up-to-date according to `sts.spec`. | ||
/// | ||
/// "Success" here means that there are no replicas running an old version, | ||
/// *not* that all updated replicas are available yet. | ||
pub fn check_statefulset_rollout_complete( | ||
sts: &StatefulSet, | ||
) -> Result<(), StatefulSetRolloutInProgress> { | ||
use outdated_statefulset::*; | ||
|
||
let status = sts.status.as_ref().map_or_else(Cow::default, Cow::Borrowed); | ||
|
||
let current_generation = sts.metadata.generation; | ||
let observed_generation = status.observed_generation; | ||
if current_generation != observed_generation { | ||
return NotYetObservedSnafu { | ||
current_generation, | ||
observed_generation, | ||
} | ||
.fail(); | ||
} | ||
|
||
let total_replicas = status.replicas; | ||
let updated_replicas = status.updated_replicas.unwrap_or(0); | ||
if total_replicas != updated_replicas { | ||
return HasOutdatedReplicasSnafu { | ||
total_replicas, | ||
updated_replicas, | ||
} | ||
.fail(); | ||
} | ||
|
||
Ok(()) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.