Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Aug 22, 2024

Description

New stackable-operator release

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But can we change the changelog entry in line 11 to Add `iter::reverse_if` helper ([#838]). This is not possible to suggest directly, because these lines are unchanged in this PR.

@xeniape xeniape added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit c77a542 Aug 22, 2024
20 checks passed
@xeniape xeniape deleted the release-0.74.0 branch August 22, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants