Skip to content

refactor(stackable-versioned): Adjust variant rename validation error span #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

refactor(stackable-versioned): Adjust variant rename validation error span #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f37a82a
refactor: Adjust variant rename validation error span
Techassi Aug 22, 2024
fcdf4bb
Merge branch 'main' into refactor/crd-versioning-variant-rename-error
Techassi Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions crates/stackable-versioned-macros/src/attrs/variant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,13 @@ impl VariantAttributes {
);

// Validate names of renames
if !self
.common
.renames
.iter()
.all(|r| r.from.is_case(Case::Pascal))
{
errors
.push(Error::custom("renamed variants must use PascalCase").with_span(&self.ident));
for rename in &self.common.renames {
if !rename.from.is_case(Case::Pascal) {
errors.push(
Error::custom("renamed variant must use PascalCase")
.with_span(&rename.from.span()),
)
}
}

errors.finish()?;
Expand Down
Loading