Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/stackable-operator/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed

- Fix the logback configuration for logback versions from 1.3.6/1.4.6 to
1.3.11/1.4.11 ([#874]).

[#874]: https://github.com/stackabletech/operator-rs/pull/874

## [0.76.0] - 2024-09-19

### Added
Expand Down
14 changes: 13 additions & 1 deletion crates/stackable-operator/src/product_logging/framework.rs
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,19 @@ pub fn create_logback_config(
</rollingPolicy>
<triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
<MaxFileSize>{max_log_file_size_in_mib}MB</MaxFileSize>
<checkIncrement>5 seconds</checkIncrement>
<!--
checkIncrement defines how often file sizes are checked, because
checking them is a relatively costly operation.
checkIncrement was introduced in the SizeBasedTriggeringPolicy in
logback 1.3.6/1.4.6 as an Integer representing milliseconds. In logback
1.3.12/1.4.12, it was changed to a Duration, also accepting a unit.
Without a given unit, milliseconds are assumed. The logback manual is
misleading: In logback 1.5.8, checkIncrement is no longer used for the
SizeAndTimeBasedFileNamingAndTriggeringPolicy, but it is still used for
the SizeBasedTriggeringPolicy!
In prior versions of logback, setting this option has no effect.
-->
<checkIncrement>5000</checkIncrement>
</triggeringPolicy>
</appender>

Expand Down