Skip to content

feat(stackable-versioned): Support visibility for CRD enum #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2024
Merged

feat(stackable-versioned): Support visibility for CRD enum #923

merged 2 commits into from
Nov 29, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Nov 29, 2024 •
edited
Loading

Part of stackabletech/issues#642

The generated CRD enum now uses the same visibility as the container definition (standalone mode) or the module (nested mode).

Before

#[versioned]
pub(crate) struct FooSpec {}

// Expanded to ...

pub enum Foo {}

After

#[versioned]
pub(crate) struct FooSpec {}

// Expands to ...

pub(crate) enum Foo {}

@Techassi Techassi self-assigned this Nov 29, 2024
@Techassi Techassi marked this pull request as ready for review November 29, 2024 09:19
@Techassi Techassi mentioned this pull request Nov 29, 2024
Open
76 tasks
NickLarsenNZ
NickLarsenNZ approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 5dcb07b Nov 29, 2024
8 of 10 checks passed
@Techassi Techassi deleted the feat/stackable-versioned-visibility-crd-enum branch November 29, 2024 09:55
@NickLarsenNZ NickLarsenNZ mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Techassi @NickLarsenNZ