fix(stackable-versioned): Remove type comparison and use into() on all field conversions #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l field conversions Note: the from/to type comparison was semantically invalid as we have no information of the actual type which might still be an equivalent string (eg: foo::TypeA could be defined in two versions of a crate).
NickLarsenNZ
force-pushed
the
fix/stackable-versioned-conversions
branch
from
8602dfc to
82fac6e
Compare
Techassi
approved these changes
Nov 29, 2024
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#642.
Remove type comparison and use
.into()on all field conversionsNote
The from/to type comparison was semantically invalid as we have no information of the actual type which might still be an equivalent string (eg:
::foo::TypeAin two versions of a crate are possibly not equivalent).Important
CI: The run_tests dependency on the run_cargodeny job has been removed.