Skip to content

fix(stackable-versioned): Check whether to skip all from impls when versioning a module #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 29, 2024
Merged

fix(stackable-versioned): Check whether to skip all from impls when versioning a module #926

merged 5 commits into from
Nov 29, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Nov 29, 2024 •
edited
Loading

Part of stackabletech/issues#642.

  • Check whether to skip all from impls when versioning a module
  • Add tests to check both full skip and per-version skip for versioned modules.

@NickLarsenNZ NickLarsenNZ self-assigned this Nov 29, 2024
@NickLarsenNZ NickLarsenNZ mentioned this pull request Nov 29, 2024
Open
76 tasks
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 7bddc97 Nov 29, 2024
8 of 10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/stackable-versioned-module-skip-from-impls branch November 29, 2024 13:41
@NickLarsenNZ NickLarsenNZ mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickLarsenNZ @Techassi