Skip to content

Conversation

nightkr
Copy link
Contributor

@nightkr nightkr commented Dec 29, 2024

Description

It's something that has come up time and time again as pretty confusing. This won't cover everything, but compared to the complete void before it should hopefully be a better starting point for understanding why it exists, how it ties together, and how it works.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@nightkr nightkr requested a review from a team December 29, 2024 08:20
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The validation part is still somewhat blurry to me. It refers to the merge protocol and not product semantics, right? Or is it something to build upon when (if ever) implementing product config 2.0 ?

@nightkr
Copy link
Contributor Author

nightkr commented Jan 7, 2025

It refers to the merge protocol and not product semantics, right?

Required fields is the only validation currently supported, but the intention is to extend it with hooks for whatever else we need.

@nightkr nightkr added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 953567d Jan 14, 2025
10 checks passed
@nightkr nightkr deleted the chore/config-docs branch January 14, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants