Skip to content

feat(stackable-operator): Add cache structure #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 29, 2025
Merged

feat(stackable-operator): Add cache structure #943

merged 16 commits into from
Jan 29, 2025

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jan 17, 2025 •
edited
Loading

Description

part of stackabletech/airflow-operator#446

Add TtlCache structure

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved (stackabletech/decisions#39)
- [x] Integration tests passed (for non trivial changes) (stackabletech/airflow-operator#573)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@siegfriedweber siegfriedweber self-assigned this Jan 17, 2025
@siegfriedweber siegfriedweber mentioned this pull request Jan 17, 2025
Closed
4 tasks
@sbernauer sbernauer self-requested a review January 20, 2025 09:11
sbernauer
sbernauer reviewed Jan 20, 2025
View reviewed changes
@siegfriedweber siegfriedweber marked this pull request as ready for review January 20, 2025 17:02
sbernauer
sbernauer previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some doc comments

nightkr
nightkr reviewed Jan 21, 2025
View reviewed changes
@sbernauer sbernauer mentioned this pull request Jan 23, 2025
Merged
sbernauer
sbernauer approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer the const generics but it is what it is 😂

@siegfriedweber siegfriedweber added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 3542f97 Jan 29, 2025
10 checks passed
@siegfriedweber siegfriedweber deleted the feat/cache branch January 29, 2025 09:18
@siegfriedweber siegfriedweber mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

+1 more reviewer

@nightkr nightkr nightkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@siegfriedweber siegfriedweber

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siegfriedweber @nightkr @sbernauer