Skip to content

fix: Remove Merge trait bound and make product_specific_common_config field public #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2025
Merged

fix: Remove Merge trait bound and make product_specific_common_config field public #946

merged 4 commits into from
Jan 20, 2025
+11 −3

Conversation

maltesander
Copy link
Member

Description

  • Remove merge trait from erase()
  • make product_specific_common_config public

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@maltesander maltesander requested a review from sbernauer January 20, 2025 13:23
@maltesander maltesander self-assigned this Jan 20, 2025
sbernauer
sbernauer requested changes Jan 20, 2025
View reviewed changes
@sbernauer sbernauer changed the title Remove merge trait and make product_specific_common_config public fix: Remove Merge trait bound and make product_specific_common_config field public Jan 20, 2025
sbernauer
sbernauer requested changes Jan 20, 2025
View reviewed changes
@maltesander maltesander enabled auto-merge January 20, 2025 13:35
@maltesander maltesander added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit e2e857b Jan 20, 2025
10 checks passed
@maltesander maltesander deleted the fix/remove-merge-trait branch January 20, 2025 13:44
@Techassi Techassi mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maltesander @sbernauer