Skip to content

Conversation

dervoeti
Copy link
Member

Description

Revert the change of the default cluster domain introduced by #939.

Reasoning: We came across some issues with TLS certificates and Kerberos keytabs and decided to make this behavior (FQDN domains for services/pods) opt-in for now. We still wanted to keep experimental support for it, but only if a user opts in by explicitly setting KUBERNETES_CLUSTER_DOMAIN to a domain with a trailing dot.

I tested this change with Zookeeper, both with and without KUBERNETES_CLUSTER_DOMAIN set, works as expected.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@dervoeti dervoeti requested a review from maltesander January 21, 2025 13:11
@dervoeti dervoeti force-pushed the fix/revert-default-clusterdomain branch from 5536b0e to b75dfc2 Compare January 21, 2025 13:26
@dervoeti dervoeti requested a review from maltesander January 21, 2025 13:27
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dervoeti dervoeti added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit fc222e4 Jan 21, 2025
10 checks passed
@dervoeti dervoeti deleted the fix/revert-default-clusterdomain branch January 21, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants