Skip to content

refactor: Adjust S3 region field structure #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 10, 2025
Merged

refactor: Adjust S3 region field structure #976

merged 7 commits into from
Mar 10, 2025

Conversation

@Techassi
Copy link
Member

@Techassi Techassi commented Mar 6, 2025

This PR adjusts the region field according to this https://github.com/stackabletech/decisions/issues/46#issuecomment-2703905958

region:
  # defaults to us-east-1 to be a non-breaking change
  name: eu-central-1

@Techassi Techassi self-assigned this Mar 6, 2025
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering Mar 6, 2025
sbernauer
sbernauer reviewed Mar 6, 2025
View reviewed changes
@Techassi Techassi mentioned this pull request Mar 7, 2025
Merged
@Techassi Techassi requested a review from sbernauer March 7, 2025 11:00
@Techassi
Copy link
Member Author

Techassi commented Mar 7, 2025 •
edited
Loading

The CI now also doesn't pass because of RUSTSEC-2025-0009. I already fixed it in a different PR: #977 (commit). We can pull this into here instead, because this PR also includes the various changes needed to fix the clippy errors.

@Techassi Techassi mentioned this pull request Mar 7, 2025
Closed
NickLarsenNZ
NickLarsenNZ requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM, just some comments need updating now that we know more

@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: In Review in Stackable Engineering Mar 10, 2025
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review March 10, 2025 09:33
@NickLarsenNZ NickLarsenNZ self-requested a review March 10, 2025 09:33
NickLarsenNZ
NickLarsenNZ approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 4cb3ddf Mar 10, 2025
9 of 10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the refactor/s3-region branch March 10, 2025 10:40
This was referenced Mar 10, 2025
Merged
Merged
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Mar 10, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@sbernauer sbernauer Awaiting requested review from sbernauer

Assignees

@Techassi Techassi

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Techassi @NickLarsenNZ @sbernauer @lfrancke