Skip to content

chore(stackable-operator): Re-introduce #950 #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2025
Merged

chore(stackable-operator): Re-introduce #950 #989

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
697a7f3
chore(stackable-operator): Deprecate initialize_logging function
Techassi Mar 19, 2025
aaf8445
chore: Merge branch 'main' into chore/deprecate-initialize-logging
Techassi Mar 31, 2025
e7fb059
fix(docs): Remove duplicate imports
Techassi Mar 31, 2025
626c69c
chore: Apply suggestion
Techassi Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/stackable-operator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ All notable changes to this project will be documented in this file.

- Add Deployments to `ClusterResource`s ([#992]).

### Changed

- Deprecate `stackable_operator::logging::initialize_logging()`. It's recommended to use `stackable-telemetry` instead ([#950], [#989]).

[#950]: https://github.com/stackabletech/operator-rs/pull/950
[#989]: https://github.com/stackabletech/operator-rs/pull/989
[#992]: https://github.com/stackabletech/operator-rs/pull/992

## [0.87.5] - 2025-03-19
Expand Down
7 changes: 2 additions & 5 deletions crates/stackable-operator/src/cluster_resources.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ use std::{
fmt::Debug,
};

#[cfg(doc)]
use k8s_openapi::api::core::v1::{NodeSelector, Pod};
use k8s_openapi::{
api::{
apps::v1::{
Expand All @@ -26,11 +28,6 @@ use snafu::{OptionExt, ResultExt, Snafu};
use strum::Display;
use tracing::{debug, info, warn};

#[cfg(doc)]
use crate::k8s_openapi::api::{
apps::v1::Deployment,
core::v1::{NodeSelector, Pod},
};
use crate::{
client::{Client, GetApi},
commons::{
Expand Down
2 changes: 2 additions & 0 deletions crates/stackable-operator/src/logging/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ impl Default for TracingTarget {
///
/// Log output can be copied to a file by setting `{env}_DIRECTORY` (e.g. `FOOBAR_OPERATOR_DIRECTORY`)
/// to a directory path. This file will be rotated regularly.
#[deprecated(note = "Use stackable-telemetry instead, use OTLP instead of Jaeger protocol")]
pub fn initialize_logging(env: &str, app_name: &str, tracing_target: TracingTarget) {
let filter = match EnvFilter::try_from_env(env) {
Ok(env_filter) => env_filter,
Expand Down Expand Up @@ -94,6 +95,7 @@ mod tests {
// NOT_SET=debug cargo test default_tracing -- --nocapture
// to see them all.
#[test]
#[allow(deprecated)]
fn default_tracing_level_is_set_to_info() {
super::initialize_logging("NOT_SET", "test", TracingTarget::None);

Expand Down
Loading