Skip to content

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Mar 21, 2025

Part of stackabletech/issues#642, needed for #968

Correctly emit type parameter defaults in generated enum and struct definitions.

@Techassi Techassi self-assigned this Mar 21, 2025
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Mar 21, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 21, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Mar 21, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer requested a review from NickLarsenNZ March 24, 2025 08:06
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit e936f70 Mar 24, 2025
10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/stackable-versioned-emit-type-parameter-defaults branch March 24, 2025 08:12
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Mar 31, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants