Skip to content

chore: Make TelemetryArguments fields pub #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
+11 −5
Merged

chore: Make TelemetryArguments fields pub #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0413361
chore: Make TelemetryArguments fields pub
Techassi Apr 2, 2025
27f4426
chore: Add changelog entry
Techassi Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/stackable-operator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Changed

- Make fields of `TelemetryArguments` public ([#998]).

[#998]: https://github.com/stackabletech/operator-rs/pull/998

## [0.89.0] - 2025-04-02

### Added
Expand Down
10 changes: 5 additions & 5 deletions crates/stackable-operator/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,23 +284,23 @@ impl ProductConfigPath {
pub struct TelemetryArguments {
/// Disable console output.
#[arg(long, env)]
no_console_output: bool,
pub no_console_output: bool,

/// Enable logging to rolling files located in the specified DIRECTORY.
#[arg(long, env, value_name = "DIRECTORY", group = "rolling_logs_group")]
rolling_logs: Option<PathBuf>,
pub rolling_logs: Option<PathBuf>,

/// Time PERIOD after which log files are rolled over.
#[arg(long, env, value_name = "PERIOD", requires = "rolling_logs_group")]
rolling_logs_period: Option<RollingPeriod>,
pub rolling_logs_period: Option<RollingPeriod>,

/// Enable exporting traces via OTLP.
#[arg(long, env)]
otlp_traces: bool,
pub otlp_traces: bool,

/// Enable exporting logs via OTLP.
#[arg(long, env)]
otlp_logs: bool,
pub otlp_logs: bool,
}

#[derive(Clone, Debug, PartialEq, Eq, strum::Display, strum::EnumString, clap::ValueEnum)]
Expand Down