Skip to content

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Sep 13, 2024

This updates (amongst other things) cargo-deny to 0.16.1 which includes breaking changes.
This PR includes the updated deny.toml

Previously we would warn on vulnerabilities, unmaintained crates etc.. This functionality has been removed in cargo-deny:

The following fields have all been removed in favor of denying all advisories by default. To ignore an advisory the ignore field can be used as before.

vulnerability - Vulnerability advisories are now deny by default
unmaintained - Unmaintained advisories are now deny by default
unsound - Unsound advisories are now deny by default
notice - Notice advisories are now deny by default

I did run the new config on hdfs operator and there were no failures but I fully expect this to cause issues in some other operator. I'll be there to clean it up and add all relevant advisories to the ignore list or fix the operators.

What I'd like to do is to merge this in operator-templating and kick off a run and then see all the broken PRs and fix them in a follow-up PR in operator-templating. If that is not okay for anyone please let me know and I'll check all operators manually before merging.
This is especially the case if anyone needs anything merged via operator-templating today or tomorrow...

# Conflicts:
#	.github/workflows/pr_pre-commit.yml
#	config/versions.yaml
@lfrancke lfrancke self-assigned this Sep 13, 2024
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One quick note: The action in version 2.0.1 uses cargo-deny 0.16.1. It might be worth to update the PR description to reflect that.

@lfrancke lfrancke enabled auto-merge September 16, 2024 07:16
@lfrancke lfrancke added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit f169868 Sep 16, 2024
2 checks passed
@lfrancke lfrancke deleted the feat/version-bumps branch September 16, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants