ci(pre-commit): Ignore j2 files for hadolint hook #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it what it was before recent broken changes).
lfrancke
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible enables whitespace trimming for j2 template blocks, which means the
COPYcommand was being hoisted into the comment on the line above.The comment was only added so that hadolint would be able to parse the Dockerfile.
We've chosen to ignore j2 files rather than disable the trimming, as that could lead to other unknown problems across many files (with the least of the problems being new lint failures).
This does mean that formatting problems will only be picked up in PRs on the operators after templating, and fixes will need pulling back into operator-templating.