Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Oct 15, 2024

'make run-dev' now installs ops in 'release.yaml' together with the operator installed by Tilt.

Add --skip-operator option to the run tests script. The use case is to skip ops installed by Tilt.

@razvan razvan requested a review from a team October 15, 2024 10:10
@nightkr
Copy link
Contributor

nightkr commented Oct 15, 2024

Strongly -1 for me for this one, I don't want run-dev to mess with the rest of the cluster.

@razvan razvan changed the title feat: make run-dev also installs ops in release.yaml feat: run-tests can skip ops during release installation Oct 15, 2024
@razvan
Copy link
Member Author

razvan commented Oct 15, 2024

Strongly -1 for me for this one, I don't want run-dev to mess with the rest of the cluster.

I see. I updated the PR.

@razvan razvan requested a review from nightkr October 15, 2024 13:56
@razvan razvan enabled auto-merge October 15, 2024 14:42
@razvan
Copy link
Member Author

razvan commented Oct 17, 2024

@nightkr is there anything else I can do here ?

Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I forgot to submit the review >.<

Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
@razvan razvan requested a review from nightkr October 17, 2024 10:51
@razvan razvan added this pull request to the merge queue Oct 17, 2024
@razvan
Copy link
Member Author

razvan commented Oct 17, 2024

thanks!

Merged via the queue into main with commit 6f9d7ca Oct 17, 2024
2 checks passed
@razvan razvan deleted the feat/run-dev-with-release branch October 17, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants