Skip to content

Conversation

sbernauer
Copy link
Member

Came up in stackabletech/operator-rs#907 (comment)

error[rejected]: failed to satisfy license requirements
  ┌─ registry+https://github.com/rust-lang/crates.io-index#[email protected]:4:44
  │
4 │ license = "ISC AND (Apache-2.0 OR ISC) AND OpenSSL"
  │            ────────────────────────────────━━━━━━━
  │            │                               │
  │            │                               rejected: license is not explicitly allowed
  │            license expression retrieved via Cargo.toml `license`
  │
  ├ OpenSSL - OpenSSL License:
  ├   - FSF Free/Libre
  ├ aws-lc-sys v0.22.0
    └── aws-lc-rs v1.10.0
        ├── rustls v0.23.15
        │   ├── hyper-rustls v0.27.3
        │   │   └── kube-client v0.96.0
        │   │       ├── kube v0.96.0
        │   │       │   ├── stackable-certs v0.3.1
        │   │       │   │   └── stackable-webhook v0.3.1
        │   │       │   │       └── (dev) stackable-telemetry v0.2.0
        │   │       │   │           └── stackable-webhook v0.3.1 (*)
        │   │       │   ├── stackable-operator v0.81.0
        │   │       │   │   ├── stackable-certs v0.3.1 (*)
        │   │       │   │   ├── (dev) stackable-operator-derive v0.3.1
        │   │       │   │   │   └── stackable-operator v0.81.0 (*)
        │   │       │   │   └── stackable-webhook v0.3.1 (*)
        │   │       │   ├── stackable-shared v0.0.1
        │   │       │   │   ├── stackable-operator v0.81.0 (*)
        │   │       │   │   ├── stackable-versioned v0.4.1
        │   │       │   │   │   └── (dev) stackable-versioned-macros v0.4.1
        │   │       │   │   │       └── stackable-versioned v0.4.1 (*)
        │   │       │   │   └── stackable-versioned-macros v0.4.1 (*)
        │   │       │   ├── stackable-versioned v0.4.1 (*)
        │   │       │   ├── stackable-versioned-macros v0.4.1 (*)
        │   │       │   └── stackable-webhook v0.3.1 (*)
        │   │       └── kube-runtime v0.96.0
        │   │           └── kube v0.96.0 (*)
        │   ├── kube-client v0.96.0 (*)
        │   └── tokio-rustls v0.26.0
        │       ├── hyper-rustls v0.27.3 (*)
        │       ├── stackable-certs v0.3.1 (*)
        │       └── stackable-webhook v0.3.1 (*)
        └── rustls-webpki v0.102.8
            └── rustls v0.23.15 (*)

@soenkeliebau
Copy link
Member

@soenkeliebau
Copy link
Member

ping @lfrancke for potential veto, I'd be happy merging this

@lfrancke
Copy link
Member

I did not read this but I trust you. So go ahead.

@sbernauer
Copy link
Member Author

So, it turns out both the aws-lc-sys and ring crates need the OpenSSL license. So I'd say we need to allow it in any case...

https://github.com/aws/aws-lc-rs/blob/cdb1651d7398148688fa4c0106135b4a82ec1e49/aws-lc-sys/Cargo.toml#L9
and
https://github.com/briansmith/ring/blob/main/LICENSE

@soenkeliebau can we merge this?

adwk67
adwk67 previously approved these changes Nov 28, 2024
@adwk67 adwk67 dismissed their stale review November 28, 2024 08:19

Pending answers to open question.

@sbernauer sbernauer self-assigned this Nov 28, 2024
@sbernauer sbernauer changed the title chore: Allow OpenSSL license (needed for aws-lc-sys crate) chore: Allow OpenSSL license (needed for ring and aws-lc-sys crates) Nov 28, 2024
@sbernauer sbernauer enabled auto-merge November 28, 2024 09:52
@sbernauer sbernauer disabled auto-merge November 28, 2024 09:53
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Both @soenkeliebau and @lfrancke have said they're fine with it.

@sbernauer sbernauer added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit e1697c5 Nov 29, 2024
2 checks passed
@sbernauer sbernauer deleted the openssl-license branch November 29, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants