Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Nov 21, 2024

This PR updates the overview image for the SDP in the readmes of the operators.

@xeniape xeniape self-assigned this Nov 21, 2024
@sbernauer sbernauer requested a review from stackfab December 9, 2024 08:03
Copy link

@stackfab stackfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really change the graphic to anything more dark mode friendlier ATM. Once we move towards DM in 2025, we need solutions for logos in general. I would like to postpone it until then. Minor side note, @sbernauer requested the HDFS image update. Unfortunately the new image exists only in a very low resolution.

@xeniape xeniape requested a review from nightkr December 9, 2024 15:40
@nightkr
Copy link
Contributor

nightkr commented Dec 9, 2024

Sure you can, @stackfab, just get rid of the rounded corners and it instantly becomes much less jarring, just like the old one:

image

image

Or you could replace the white background with a transparent one, but that would be much easier with access to the original source files instead of dragging things around in Krita for five minutes.

@sbernauer
Copy link
Member

We can merge as is for now, and have a follow-up regarding the graphic in general (modernize, include source, dark mode)

@stackfab
Copy link

stackfab commented Dec 16, 2024

I may provide an slightly updated version until noon (16/12/24)

@xeniape xeniape added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit bf9cb86 Dec 17, 2024
2 checks passed
@xeniape xeniape deleted the docs/update-stackable-overview branch December 17, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants