Add script to run and automatically retry tests#542
Merged
Conversation
lfrancke
force-pushed
the
feat/auto-retry
branch
from
7bbc2ba to
9a967dd
Compare
Member
|
I think I would prefer to have |
Member
Author
|
I'm fine with that. I'll see if more comments are added and can then implement it. |
Member
|
I modified a smoke test (so that it fails) and ran
INFO:root:Expanding test case id [smoke_opa-1.0.1_openshift-false]
INFO:root:Expanding test case id [smoke_opa-1.4.2_openshift-false]
Traceback (most recent call last):
File "/nix/store/dk3mknkr5xfkd6wm4zznhy4h8zjcxv1w-beku-stackabletech-0.0.10-/bin/.beku-wrapped", line 9, in <module>
sys.exit(main())
^^^^^^
File "/nix/store/dk3mknkr5xfkd6wm4zznhy4h8zjcxv1w-beku-stackabletech-0.0.10-/lib/python3.12/site-packages/beku/main.py", line 97, in main
return expand(
^^^^^^^
File "/nix/store/dk3mknkr5xfkd6wm4zznhy4h8zjcxv1w-beku-stackabletech-0.0.10-/lib/python3.12/site-packages/beku/kuttl.py", line 332, in expand
test_case.expand(template_dir, output_dir, namespace)
File "/nix/store/dk3mknkr5xfkd6wm4zznhy4h8zjcxv1w-beku-stackabletech-0.0.10-/lib/python3.12/site-packages/beku/kuttl.py", line 149, in expand
test_source.build_destination()
File "/nix/store/dk3mknkr5xfkd6wm4zznhy4h8zjcxv1w-beku-stackabletech-0.0.10-/lib/python3.12/site-packages/beku/kuttl.py", line 79, in build_destination
with open(dest, encoding="utf8", mode="w") as stream:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'tests/_work/tests/smoke/smoke_opa-1.4.2_openshift-false/01-install-vector-aggregator-discovery-configmap.yaml'
ERROR:root:beku failedIs this maybe because of multiple processes running in parallel? |
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
Author
|
Can you give me the full command you ran and maybe a bit more output? And the three namespaces it mentions are still there. |
Member
|
I currently don't have any output, but at least I can provide the full command :)
Yeah, because you specified |
Member
Author
|
Ahhhh! Now I understand. Thank you. I'll fix that and try the run again. |
Member
Author
|
I also found the issue (well you already hinted at it) with the message about the missing directories. https://github.com/stackabletech/beku.py/pull/7/files I see two possibilities and I'm fine with both (or another option I haven't thought of)
Any preferences/ideas? |
Member
|
Option 1 sounds a bit nicer but I cant judge if it's worth the effort |
lfrancke
force-pushed
the
feat/auto-retry
branch
from
9a967dd to
6e8faaa
Compare
Member
Author
|
I have implemented option 1 now along with other improvements |
- keep-failed-namespaces has been changed to delete-failed-namespaces (default false) - A unique work directory is created for each test run to avoid interference - The logs now contain the exact command that was used to run the tests - Script tried to delete already deleted namespaces
lfrancke
force-pushed
the
feat/auto-retry
branch
from
6e8faaa to
3e7c4fb
Compare
sbernauer
approved these changes
Aug 5, 2025
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
I guess we can just give this a try in CI and see how it goes :)
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script can be used to run the full test suite and then automatically retry the failing tests a configurable number of times. It can optionally keep the failed namespaces and it writes all the logs to files.
I did create this to run tests locally on my machine but I hope we can also make it usable for CI builds.
I am not the biggest fan of the output as it is very noisy but on the other hand I also don't want to miss crucial information during debugging.
This will generate output like this: