Skip to content

Renaming .jar file according to new supported versions #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2024
Merged

Renaming .jar file according to new supported versions #438

merged 2 commits into from
Jul 26, 2024

Conversation

Maleware
Copy link
Member

@Maleware Maleware commented Jul 25, 2024 •
edited by sbernauer
Loading

Description

Fixing ny-public test by adding 3.4.3.jar build from stackabletech/ny-tlc-report#8

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@Maleware Maleware self-assigned this Jul 25, 2024
@Maleware Maleware mentioned this pull request Jul 25, 2024
Closed
sbernauer
sbernauer requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use https://github.com/stackabletech/ny-tlc-report to build the new jar file (e.g. have a look at stackabletech/ny-tlc-report@6f1877e or stackabletech/ny-tlc-report@cfeb297)

sbernauer
sbernauer approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@Maleware Maleware enabled auto-merge July 26, 2024 08:17
@Maleware Maleware added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 297b7da Jul 26, 2024
31 checks passed
@Maleware Maleware deleted the fix/ny-public-test-2 branch July 26, 2024 08:31
Maleware added a commit that referenced this pull request Jul 26, 2024
@Maleware @sbernauer
Renaming .jar file according to new supported versions (#438)
1ea7492 
* Renaming .jar file according to new supported versions

* Update jar

---------

Co-authored-by: Sebastian Bernauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@Maleware Maleware

Labels
release/24.7.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maleware @sbernauer