Skip to content

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Oct 21, 2024

Description

Allow specifying a custom log directory

Closes #464

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved (stackabletech/decisions#32)
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber self-assigned this Oct 21, 2024
@siegfriedweber siegfriedweber requested a review from a team October 21, 2024 08:21
@siegfriedweber siegfriedweber changed the title Feat/custom log directory feat: custom log directory Oct 21, 2024
@razvan razvan requested review from razvan and removed request for a team October 21, 2024 09:16
razvan
razvan previously approved these changes Oct 21, 2024
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions.

siegfriedweber and others added 2 commits October 21, 2024 11:50
Co-authored-by: Razvan-Daniel Mihai <[email protected]>
@siegfriedweber siegfriedweber added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 45c1e7a Oct 21, 2024
31 checks passed
@siegfriedweber siegfriedweber deleted the feat/custom-log-directory branch October 21, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spark History Server support for Azure Data Lake Storage Gen2 (ADLS)
2 participants