Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 4, 2025

Description

Part of stackabletech/issues#584

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer changed the title Add field to CRD feat: Support configuring JVM arguments Mar 4, 2025
@sbernauer
Copy link
Member Author

@sbernauer sbernauer requested a review from maltesander March 5, 2025 08:06
@sbernauer
Copy link
Member Author

Tests passed

@sbernauer sbernauer removed the request for review from maltesander March 5, 2025 08:06
@sbernauer sbernauer self-assigned this Mar 5, 2025
@sbernauer sbernauer marked this pull request as ready for review March 5, 2025 10:56
@maltesander maltesander self-requested a review March 5, 2025 11:00
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will test a little tomorrow!

@sbernauer sbernauer requested a review from maltesander March 6, 2025 14:51
maltesander
maltesander previously approved these changes Mar 6, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer enabled auto-merge March 7, 2025 07:59
@sbernauer sbernauer added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit b28d8a4 Mar 7, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/jvm-arguments branch March 7, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants