Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented May 26, 2025

Description

CI https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/24/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@razvan razvan self-assigned this May 26, 2025
@razvan razvan moved this to Development: In Progress in Stackable Engineering May 26, 2025
@razvan razvan marked this pull request as ready for review May 26, 2025 12:05
@razvan razvan requested a review from sbernauer May 26, 2025 12:06
@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering May 26, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 26, 2025
sbernauer
sbernauer previously approved these changes May 27, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

Co-authored-by: Sebastian Bernauer <[email protected]>
@razvan
Copy link
Member Author

razvan commented May 27, 2025

The failing test is not releated to this PR:

--- FAIL: kuttl (3846.71s)
    --- FAIL: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-connect_openshift-false_spark-connect-3.5.5_spark-connect-client-3.5.5 (225.11s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-false_spark-3.5.5 (123.51s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-false_spark-3.5.5_s3-use-tls-true (193.71s)
        --- PASS: kuttl/harness/spark-history-server_openshift-false_spark-3.5.5_s3-use-tls-true (327.09s)
        --- PASS: kuttl/harness/overrides_openshift-false_spark-3.5.5 (131.87s)
        --- PASS: kuttl/harness/smoke_openshift-false_spark-3.5.5_s3-use-tls-true (180.88s)
        --- PASS: kuttl/harness/resources_openshift-false_spark-3.5.5 (85.23s)
        --- PASS: kuttl/harness/iceberg_openshift-false_spark-3.5.5 (98.95s)
        --- PASS: kuttl/harness/hbase-connector_openshift-false_spark-3.5.5_hbase-2.6.1_hdfs-latest-3.4.1_zookeeper-latest-3.9.3 (337.24s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-false_spark-3.5.5 (145.95s)
        --- PASS: kuttl/harness/logging_openshift-false_spark-3.5.5_ny-tlc-report-0.2.0 (393.80s)
        --- PASS: kuttl/harness/spark-examples_openshift-false_spark-3.5.5 (77.36s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-false_spark-3.5.5_ny-tlc-report-0.2.0 (154.66s)
        --- PASS: kuttl/harness/custom-log-directory_openshift-false_spark-3.5.5_hdfs-latest-3.4.1_zookeeper-latest-3.9.3 (206.57s)
        --- PASS: kuttl/harness/delta-lake_openshift-false_spark-delta-lake-3.5.5_delta-3.1.0 (231.09s)
        --- FAIL: kuttl/harness/spark-pi-public-s3_openshift-false_spark-3.5.5 (931.77s)
FAIL
ERROR:root:kuttl failed

@razvan razvan enabled auto-merge May 27, 2025 06:57
@razvan razvan requested a review from sbernauer May 27, 2025 07:46
@razvan razvan added this pull request to the merge queue May 27, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 27, 2025
Merged via the queue into main with commit f415bad May 27, 2025
16 of 17 checks passed
@razvan razvan deleted the fix/watch-sts branch May 27, 2025 08:21
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants