Skip to content

chore: replace jmx exporter with built in Prometheus support #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 13, 2025
Merged

chore: replace jmx exporter with built in Prometheus support #584

merged 8 commits into from
Jun 13, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Jun 12, 2025 •
edited by maltesander
Loading

Description

Part of: #582

🟢 CI https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/33/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Jun 12, 2025
@razvan razvan mentioned this pull request Jun 11, 2025
Closed
2 tasks
@razvan razvan marked this pull request as ready for review June 12, 2025 12:52
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Jun 12, 2025
@razvan razvan requested a review from a team June 12, 2025 13:35
@razvan
Copy link
Member Author

razvan commented Jun 12, 2025 •
edited
Loading

Release Notes

This release enables the built in Prometheus servlet for metric scraping. The existing JMX exporter is still enabled but it is deprecated and it will be removed in a future release.

@razvan razvan added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 12, 2025
@maltesander maltesander self-requested a review June 13, 2025 09:05
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 13, 2025
maltesander
maltesander requested changes Jun 13, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, LGTM! One minor nitpick.

@razvan @maltesander
Update CHANGELOG.md
bb60f36 
Co-authored-by: Malte Sander <[email protected]>
maltesander
maltesander approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan
Copy link
Member Author

razvan commented Jun 13, 2025

thanks! it needs another approval now.

@razvan razvan enabled auto-merge June 13, 2025 11:44
@razvan razvan added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit e8a4654 Jun 13, 2025
17 checks passed
@razvan razvan deleted the chore/remove-jmx-exporter branch June 13, 2025 12:03
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jun 17, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jun 20, 2025
@lfrancke
Copy link
Member

We probably need to adjust the release note snippet, right?

@razvan
Copy link
Member Author

razvan commented Jun 30, 2025

We probably need to adjust the release note snippet, right?

Done.

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@razvan razvan

Labels
release/25.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvan @lfrancke @maltesander