Skip to content

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Jul 28, 2025

Description

Fixes test timing issues.

  • split assert for the executor pods out into a separate step
  • increase some timeouts
  • increase activeDeadlineSeconds for the connect Job

(the timeouts are maybe a little generous for k3s and okd run via jenkins, but locally they may be not so far off, depending on download speeds).

Jenkins:
🟢 k3s
🟢 Openshift

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 moved this to Development: In Progress in Stackable Engineering Jul 28, 2025
@adwk67 adwk67 self-assigned this Jul 28, 2025
@adwk67 adwk67 marked this pull request as ready for review July 28, 2025 10:15
@adwk67 adwk67 requested a review from a team July 28, 2025 10:15
@adwk67 adwk67 moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jul 28, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 28, 2025
@sbernauer sbernauer self-requested a review July 28, 2025 11:58
adwk67 and others added 3 commits July 28, 2025 14:44
I left out the sparkconnectservers check as we check the statefulset, and that waits for the driver. We can keep this check in, but, just for my understanding, do we *need* both?

Co-authored-by: Sebastian Bernauer <[email protected]>
@adwk67 adwk67 requested a review from sbernauer July 28, 2025 13:01
@adwk67 adwk67 enabled auto-merge July 28, 2025 13:16
@adwk67 adwk67 added this pull request to the merge queue Jul 28, 2025
Merged via the queue into main with commit 0de1249 Jul 28, 2025
17 checks passed
@adwk67 adwk67 deleted the fix/spark-connect-test branch July 28, 2025 13:20
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jul 28, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants