Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Aug 15, 2025

Description

Fixes #600

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Aug 15, 2025
@razvan razvan requested a review from a team August 15, 2025 09:57
sbernauer
sbernauer previously approved these changes Aug 15, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Co-authored-by: Sebastian Bernauer <[email protected]>
@razvan razvan added this pull request to the merge queue Aug 15, 2025
@razvan
Copy link
Member Author

razvan commented Aug 15, 2025

thanks for the approval!

Merged via the queue into main with commit 07caf90 Aug 15, 2025
17 checks passed
@razvan razvan deleted the issues/600 branch August 15, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SparkConnectServer: imagePullSecret is not passed to Spark executor pods

3 participants