Skip to content

chore(getting_started): Replace templating instructions with make #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore(getting_started): Replace templating instructions with make #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions docs/modules/superset/examples/getting_started/getting_started.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,7 @@
set -euo pipefail

# DO NOT EDIT THE SCRIPT
# Instead, update the j2 template, and regenerate it for dev:
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
# helm:
# repo_name: stackable-dev
# repo_url: https://repo.stackable.tech/repository/helm-dev/
# versions:
# commons: 0.0.0-dev
# listener: 0.0.0-dev
# secret: 0.0.0-dev
# superset: 0.0.0-dev
# EOF
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.

# TODO (@NickLarsenNZ): Use bitnami/postgres chart, and add version var to the above list
# See similar changes in: https://github.com/stackabletech/hive-operator/pull/489/commits/8189f196f018c009370ae9b07a3f9609ee2e8681
Expand Down
12 changes: 1 addition & 11 deletions docs/modules/superset/examples/getting_started/getting_started.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,7 @@
set -euo pipefail

# DO NOT EDIT THE SCRIPT
# Instead, update the j2 template, and regenerate it for dev:
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
# helm:
# repo_name: stackable-dev
# repo_url: https://repo.stackable.tech/repository/helm-dev/
# versions:
# commons: 0.0.0-dev
# listener: 0.0.0-dev
# secret: 0.0.0-dev
# superset: 0.0.0-dev
# EOF
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.

# TODO (@NickLarsenNZ): Use bitnami/postgres chart, and add version var to the above list
# See similar changes in: https://github.com/stackabletech/hive-operator/pull/489/commits/8189f196f018c009370ae9b07a3f9609ee2e8681
Expand Down
Loading