Skip to content

Conversation

@soenkeliebau
Copy link
Member

@soenkeliebau soenkeliebau commented Nov 22, 2024

Description

The name of the ServiceAccount contains now the cluster name instead of the product name. This allows independent Superset clusters in the same namespace.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed locally
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber changed the title Use patched version of op-rs that hopefully addresses SUP-148. Use patched version of op-rs that addresses SUP-148. Nov 22, 2024
@siegfriedweber siegfriedweber self-assigned this Nov 22, 2024
@siegfriedweber siegfriedweber requested a review from a team November 24, 2024 12:04
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber siegfriedweber added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 39be16f Nov 25, 2024
16 of 17 checks passed
@siegfriedweber siegfriedweber deleted the fix/SUP-148 branch November 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants