Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Jan 17, 2025

Description

  • merge templating PR
  • change all references, use search-and-replace to find things (Makefile, Dockerfiles, operator Helm Charts, default,nix, kuttl tests, ....)
  • ensure that kuttl tests are running
  • for every image reference, ensure that the image is actually in Harbor (and image hash is the same as before?)

Openshift tests:

--- PASS: kuttl (666.75s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/resources_superset-latest-4.0.2_openshift-true (145.03s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-no-tls_openshift-true (145.47s)
        --- PASS: kuttl/harness/logging_superset-4.0.2_openshift-true (104.47s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-insecure-tls_openshift-true (121.68s)
        --- PASS: kuttl/harness/oidc_superset-4.0.2_openshift-true (148.64s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-4.0.2_openshift-true (264.06s)
        --- PASS: kuttl/harness/smoke_superset-4.0.2_openshift-true (142.99s)
        --- PASS: kuttl/harness/druid-connection_superset-4.0.2_openshift-true (110.94s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-server-verification-tls_openshift-true (116.60s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape self-assigned this Jan 17, 2025
@adwk67 adwk67 assigned adwk67 and unassigned xeniape Jan 30, 2025
@adwk67 adwk67 marked this pull request as ready for review January 30, 2025 09:37
adwk67
adwk67 previously approved these changes Jan 30, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape requested a review from adwk67 January 30, 2025 10:09
@adwk67 adwk67 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 5fac568 Jan 30, 2025
17 checks passed
@adwk67 adwk67 deleted the chore/switch-to-oci-repo branch January 30, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants