Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Feb 12, 2025

Description

Part of stackabletech/issues#642

--- PASS: kuttl (750.67s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/resources_superset-latest-4.1.1_openshift-false (103.78s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-4.1.1_openshift-false (117.03s)
        --- PASS: kuttl/harness/logging_superset-4.0.2_openshift-false (185.71s)
        --- PASS: kuttl/harness/ldap_superset-4.1.1_ldap-authentication-server-verification-tls_openshift-false (137.80s)
        --- PASS: kuttl/harness/ldap_superset-4.1.1_ldap-authentication-no-tls_openshift-false (124.60s)
        --- PASS: kuttl/harness/ldap_superset-4.1.1_ldap-authentication-insecure-tls_openshift-false (100.91s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-server-verification-tls_openshift-false (103.86s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-no-tls_openshift-false (104.41s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-insecure-tls_openshift-false (101.61s)
        --- PASS: kuttl/harness/smoke_superset-4.1.1_openshift-false (96.96s)
        --- PASS: kuttl/harness/logging_superset-4.1.1_openshift-false (115.13s)
        --- PASS: kuttl/harness/oidc_superset-4.1.1_openshift-false (137.10s)
        --- PASS: kuttl/harness/oidc_superset-4.0.2_openshift-false (123.61s)
        --- PASS: kuttl/harness/smoke_superset-4.0.2_openshift-false (98.51s)
        --- PASS: kuttl/harness/druid-connection_superset-4.1.1_openshift-false (192.16s)
        --- PASS: kuttl/harness/druid-connection_superset-4.0.2_openshift-false (184.04s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape self-assigned this Feb 12, 2025
@xeniape xeniape marked this pull request as ready for review February 12, 2025 09:01
@NickLarsenNZ NickLarsenNZ self-requested a review February 12, 2025 14:12
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changes around the imports are required.

@xeniape xeniape requested a review from NickLarsenNZ February 17, 2025 12:44
@xeniape xeniape requested a review from Techassi February 24, 2025 12:10
NickLarsenNZ
NickLarsenNZ previously approved these changes Feb 25, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a question about some un-versioned types.

@sbernauer sbernauer moved this from Development: In Review to Development: Track in Stackable Engineering Mar 3, 2025
@sbernauer
Copy link
Member

Currently waiting for kube-rs/kube#1704

@sbernauer sbernauer moved this from Development: Track to Development: In Progress in Stackable Engineering Mar 17, 2025
@xeniape xeniape moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Mar 18, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 18, 2025
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, two small comments.

@xeniape xeniape requested a review from Techassi March 18, 2025 11:55
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit c7273b5 Mar 19, 2025
17 checks passed
@xeniape xeniape deleted the chore/add-crd-versioning branch March 19, 2025 14:01
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Mar 19, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants