Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 11, 2025

Description

Pulls in stackabletech/operator-rs#1090

Should fix the integration tests

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer requested a review from a team September 11, 2025 06:39
@sbernauer sbernauer self-assigned this Sep 11, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Sep 11, 2025
@adwk67 adwk67 requested review from adwk67 and removed request for a team September 12, 2025 09:40
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 12, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests 🟢. Locally the opa test sometimes fails when run as part of a suite, but is fine on a re-try.

@sbernauer sbernauer added this pull request to the merge queue Sep 12, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 12, 2025
@sbernauer
Copy link
Member Author

Thanks for running the tests!

Merged via the queue into main with commit 4ba0d25 Sep 12, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/probe branch September 12, 2025 11:27
@lfrancke
Copy link
Member

The description is a bit leight on information. This fixed a bug. Could you add release notes? Or was this bug never released.

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Sep 22, 2025
@sbernauer
Copy link
Member Author

It's a fixup of #654, so internal.
Changelog was updated accordingly

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants