Skip to content

chore: expand opa-authorization test to run with all supported trino versions #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xeniape merged 1 commit into from
Mar 26, 2025
Merged

chore: expand opa-authorization test to run with all supported trino versions #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/templates/kuttl/opa-authorization/20-install-trino.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ metadata:
name: trino
spec:
image:
{% if test_scenario['values']['trino-latest'].find(",") > 0 %}
custom: "{{ test_scenario['values']['trino-latest'].split(',')[1] }}"
productVersion: "{{ test_scenario['values']['trino-latest'].split(',')[0] }}"
{% if test_scenario['values']['trino'].find(",") > 0 %}
custom: "{{ test_scenario['values']['trino'].split(',')[1] }}"
productVersion: "{{ test_scenario['values']['trino'].split(',')[0] }}"
{% else %}
productVersion: "{{ test_scenario['values']['trino-latest'] }}"
productVersion: "{{ test_scenario['values']['trino'] }}"
{% endif %}
pullPolicy: IfNotPresent
clusterConfig:
Expand Down
4 changes: 4 additions & 0 deletions ...ates/kuttl/opa-authorization/check-opa.py → ...s/kuttl/opa-authorization/check-opa.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@
{
"query": "SET SESSION iceberg.test=true",
# The requests are authorized, just a fake property
{% if test_scenario['values']['trino'] == '470' %}
"error": "Session property iceberg.test does not exist",
{% else %}
"error": "Session property 'iceberg.test' does not exist",
{% endif %}
},
# ## SCHEMA ##
# ExecuteQuery, AccessCatalog, ShowSchemas, SelectFromColumns, FilterCatalogs, FilterSchemas
Expand Down
2 changes: 1 addition & 1 deletion tests/test-definition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ tests:
- openshift
- name: opa-authorization
dimensions:
- trino-latest
- trino
- hive-latest
- opa
- keycloak
Expand Down