Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jun 10, 2025

Part of stackabletech/docker-images#1082.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@NickLarsenNZ

This comment was marked as resolved.

It turns out only Trino 470 has the different error output

This reverts commit b8b6e78.
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jun 12, 2025

Ok, tests for 476 pass now.

--- PASS: kuttl/harness/authentication_trino-latest-476_ldap-use-tls-false_openshift-false (257.09s)
--- PASS: kuttl/harness/authentication_trino-latest-476_ldap-use-tls-true_openshift-false (295.90s)
--- PASS: kuttl/harness/cluster-operation_trino-latest-476_openshift-false (66.18s)
--- PASS: kuttl/harness/logging_trino-476_openshift-false (78.88s)
--- PASS: kuttl/harness/opa-authorization_trino-476_hive-latest-4.0.1_opa-1.4.2_keycloak-25.0.0_openshift-false (362.59s)
--- PASS: kuttl/harness/orphaned-resources_trino-latest-476_openshift-false (48.71s)
--- PASS: kuttl/harness/resources_trino-latest-476_openshift-false (65.28s)
--- PASS: kuttl/harness/smoke_trino-476_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (481.82s)
--- PASS: kuttl/harness/smoke_trino-476_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (427.10s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-false_use-tls-false_use-internal-tls-false_openshift-false (70.43s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-false_use-tls-false_use-internal-tls-true_openshift-false (73.07s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-false_use-tls-true_use-internal-tls-false_openshift-false (72.73s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-false_use-tls-true_use-internal-tls-true_openshift-false (74.42s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-true_use-tls-false_use-internal-tls-false_openshift-false (68.49s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-true_use-tls-false_use-internal-tls-true_openshift-false (72.80s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-true_use-tls-true_use-internal-tls-false_openshift-false (72.36s)
--- PASS: kuttl/harness/tls_trino-latest-476_use-authentication-true_use-tls-true_use-internal-tls-true_openshift-false (75.03s)


@maltesander maltesander self-requested a review June 12, 2025 09:17
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 12, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jun 12, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Jun 12, 2025
Merged via the queue into main with commit 4940939 Jun 12, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the chore/bump-trino-before-25.7.0 branch June 12, 2025 09:56
NickLarsenNZ added a commit that referenced this pull request Jun 12, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants