Skip to content

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jul 22, 2024

### Run getting_started.sh via
- [x] `stackablectl`
- [x] `helm`

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jul 22, 2024

In the helm case, I see a warning (but the script still succeeds):

warning: couldn't attach to pod/my-pod, falling back to streaming logs: unable to upgrade connection: container my-pod not found in pod my-pod_default

I tried adding --wait but the option is being removed and apparently unused by kubectl run. We might needs to add a sleep or something.

This worked each time when I manually ran it (~4 times):

kubectl run my-pod \
  --stdin --tty --quiet --restart=Never \
  --image docker.stackable.tech/stackable/zookeeper:3.9.2-stackable0.0.0-dev -- \
  bin/zkCli.sh -server simple-zk-server-default:2282 ls / > /dev/null && \
  kubectl logs my-pod && \
  kubectl delete pods my-pod

In terms of correctness in the docs, this is fine.

@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review July 22, 2024 15:24
@NickLarsenNZ NickLarsenNZ enabled auto-merge July 22, 2024 15:24
@NickLarsenNZ NickLarsenNZ disabled auto-merge July 22, 2024 15:43
@NickLarsenNZ NickLarsenNZ enabled auto-merge July 22, 2024 15:45
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit ce6119a Jul 22, 2024
31 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/getting-started-24.7 branch July 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants