Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Mar 19, 2025

Description

--- PASS: kuttl (388.52s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/znode_zookeeper-latest-3.9.3_openshift-false (44.01s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-false_use-client-auth-tls-false_openshift-false (70.11s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-true_use-client-auth-tls-true_openshift-false (126.15s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-true_use-client-auth-tls-true_openshift-false (126.40s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-true_use-client-auth-tls-false_openshift-false (74.02s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-false_use-client-auth-tls-true_openshift-false (71.69s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-false_use-client-auth-tls-true_openshift-false (75.67s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-true_use-client-auth-tls-false_openshift-false (68.90s)
        --- PASS: kuttl/harness/logging_zookeeper-3.9.3_openshift-false (60.48s)
        --- PASS: kuttl/harness/logging_zookeeper-3.9.2_openshift-false (59.12s)
        --- PASS: kuttl/harness/delete-rolegroup_zookeeper-3.9.3_openshift-false (40.50s)
        --- PASS: kuttl/harness/cluster-operation_zookeeper-latest-3.9.3_openshift-false (44.20s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-false_use-client-auth-tls-false_openshift-false (55.23s)
        --- PASS: kuttl/harness/delete-rolegroup_zookeeper-3.9.2_openshift-false (89.68s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

NickLarsenNZ
NickLarsenNZ previously approved these changes Mar 20, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a formatting suggestion

@NickLarsenNZ NickLarsenNZ moved this to Development: In Review in Stackable Engineering Mar 20, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ enabled auto-merge March 20, 2025 08:10
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Mar 20, 2025
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 94c7be4 Mar 20, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the chore/bump-stackable-operator branch March 20, 2025 08:27
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants