Skip to content

feat!: Use Tracing::pre_configured from stackable-telemetry #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025
Merged

feat!: Use Tracing::pre_configured from stackable-telemetry #934

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df018e1
chore: Bump stackable-operator and use re-exports
NickLarsenNZ Apr 9, 2025
d465d33
feat!: Use `Tracing::pre_configured` from stackable-telemetry
NickLarsenNZ Apr 9, 2025
1c8e5fb
chore: Update changelog
NickLarsenNZ Apr 9, 2025
0ab6a5c
chore: cargo update && make regenerate-nix
NickLarsenNZ Apr 9, 2025
8840c09
Apply suggestions from code review
NickLarsenNZ Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ All notable changes to this project will be documented in this file.

### Changed

- Replace stackable-operator `initialize_logging` with stackable-telemetry `Tracing` ([#927]).
- BREAKING: The file log directory was set by `ZOOKEEPER_OPERATOR_LOG_DIRECTORY`,
and is now set by `ROLLING_LOGS` (or via `--rolling-logs <DIRECTORY>`).
- BREAKING: Replace stackable-operator `initialize_logging` with stackable-telemetry `Tracing` ([#927], [#934]).
- The console log level was set by `ZOOKEEPER_OPERATOR_LOG`, and is now set by `CONSOLE_LOG`.
- The file log level was set by `ZOOKEEPER_OPERATOR_LOG`, and is now set by `FILE_LOG`.
- The file log directory was set by `ZOOKEEPER_OPERATOR_LOG_DIRECTORY`, and is now set
by `ROLLING_LOGS_DIR` (or via `--rolling-logs <DIRECTORY>`).
- Replace stackable-operator `print_startup_string` with `tracing::info!` with fields.
- BREAKING: Inject the vector aggregator address into the vector config using the env var `VECTOR_AGGREGATOR_ADDRESS` instead
of having the operator write it to the vector config ([#933]).
Expand All @@ -18,8 +20,9 @@ All notable changes to this project will be documented in this file.
- Use `json` file extension for log files ([#932]).

[#927]: https://github.com/stackabletech/zookeeper-operator/pull/927
[#933]: https://github.com/stackabletech/zookeeper-operator/pull/XXX
[#933]: https://github.com/stackabletech/zookeeper-operator/pull/934
[#932]: https://github.com/stackabletech/zookeeper-operator/pull/932
[#934]: https://github.com/stackabletech/zookeeper-operator/pull/xxx

## [25.3.0] - 2025-03-21

Expand Down
32 changes: 17 additions & 15 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

85 changes: 52 additions & 33 deletions Cargo.nix
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ repository = "https://github.com/stackabletech/zookeeper-operator"

[workspace.dependencies]
product-config = { git = "https://github.com/stackabletech/product-config.git", tag = "0.7.0" }
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.90.0" }
stackable-telemetry = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-telemetry-0.4.0" }
stackable-versioned = { git = "https://github.com/stackabletech/operator-rs.git", features = ["k8s"], tag = "stackable-versioned-0.7.1" }
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", features = ["telemetry", "versioned"], tag = "stackable-operator-0.91.1" }

anyhow = "1.0"
built = { version = "0.7", features = ["chrono", "git2"] }
Expand Down
16 changes: 8 additions & 8 deletions crate-hashes.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions rust/operator-binary/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ build = "build.rs"
[dependencies]
product-config.workspace = true
stackable-operator.workspace = true
stackable-telemetry.workspace = true
stackable-versioned.workspace = true

anyhow.workspace = true
clap.workspace = true
Expand Down
Loading