Skip to content

[fix]: shell commands execution failure on app reload #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecodacus merged 2 commits into from
Nov 29, 2024
Merged

[fix]: shell commands execution failure on app reload #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fb6480
[fix]: shell commands failing on app reload
PuneetP16 Nov 26, 2024
5add317
Update action-runner.ts
thecodacus Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/lib/runtime/action-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,12 @@ export class ActionRunner {

this.#currentExecutionPromise = this.#currentExecutionPromise
.then(() => {
this.#executeAction(actionId, isStreaming);
return this.#executeAction(actionId, isStreaming);
})
.catch((error) => {
console.error('Action failed:', error);
});
return this.#currentExecutionPromise;
Copy link
Collaborator

@thecodacus thecodacus Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this line for inter artifact chaining to work properly in workbench level

}

async #executeAction(actionId: string, isStreaming: boolean = false) {
Expand Down
2 changes: 1 addition & 1 deletion app/utils/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ interface Logger {
setLevel: (level: DebugLevel) => void;
}

let currentLevel: DebugLevel = (import.meta.env.VITE_LOG_LEVEL ?? import.meta.env.DEV) ? 'debug' : 'info';
let currentLevel: DebugLevel = import.meta.env.VITE_LOG_LEVEL ?? import.meta.env.DEV ? 'debug' : 'info';

const isWorker = 'HTMLRewriter' in globalThis;
const supportsColor = !isWorker;
Expand Down