Skip to content

Conversation

@HuynhDoTanThanh
Copy link

Integrate AzureOpenAI

Integrate AzureOpenAI
@HuynhDoTanThanh HuynhDoTanThanh changed the title Integrate AzureOpenAI feat: Integrate AzureOpenAI Oct 27, 2024
@HuynhDoTanThanh HuynhDoTanThanh changed the title feat: Integrate AzureOpenAI feat: added AzureOpenAI Oct 27, 2024
Copy link

@srdosramos srdosramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration works but the model deployments on azure needs to have a unique name than the ones on the others providers. I tested on a deployment that has the name gpt-4o and gpt-4 and in both cases the code thinks that the provider is OpenAI instead of AzureOpenAI

@hardikcc
Copy link

hardikcc commented Nov 4, 2024

I am getting error which says that the token is being not applied to the openai requests.

@bakes82
Copy link

bakes82 commented Nov 4, 2024

This seems to only support the key approach, which is not a best practice for azure, you should be using service principals. Also if you work in any larger corp env you wont have an key as most of these instance are load balanced behind an APIM.

@axen2u
Copy link

axen2u commented Nov 8, 2024

Hi @HuynhDoTanThanh It is not getting url correctly when selected AzureOpenAI for me. It use Anthropic url.

@chrismahoney
Copy link
Collaborator

Tagging to cover with #276 post provider refactor.

@chrismahoney chrismahoney added the duplicate This issue or pull request already exists label Nov 14, 2024
@chrismahoney chrismahoney self-assigned this Nov 14, 2024
@dustinwloring1988 dustinwloring1988 added model-provider This is a model provider addition and removed duplicate This issue or pull request already exists labels Dec 2, 2024
return [];
}
const api_key = import.meta.env.AZURE_OPENAI_API_KEY;
const response = await fetch(`${base_url}/openai/deployments?api-version=2023-03-15-preview`, {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HuynhDoTanThanh would it make sense to make the API Version parametrizable in .env as well?

@kheuch2018
Copy link

Hello @HuynhDoTanThanh,

having same issue as @axen2u. It's using anthropic instead of azure url.

can you please check ?

@Digitl-Alchemyst
Copy link
Collaborator

This PR is increasing in conflict with main
Multiple Errors reported from various testers
Far from best practices for azure open ai
No reply from @HuynhDoTanThanh since he posted

Closing. If you fix the implementation and clean up all the errors please resubmit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model-provider This is a model provider addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.