Skip to content

Conversation

@AmirSa12
Copy link
Member

@AmirSa12 AmirSa12 commented Nov 22, 2024

closes #268

@AmirSa12 AmirSa12 marked this pull request as draft November 22, 2024 09:26
@continuous-releases-staging
Copy link

continuous-releases-staging bot commented Nov 22, 2024

Open in Stackblitzexample-1example-2

npm i https://a04db65f.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@286
npm i https://a04db65f.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-a@286
npm i https://a04db65f.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-b@286

commit: f3a6197

@AmirSa12 AmirSa12 marked this pull request as ready for review November 22, 2024 10:12
@AmirSa12 AmirSa12 requested a review from Aslemammad November 22, 2024 10:12
@AmirSa12 AmirSa12 changed the title feat: set package manager manually feat: --packageManager Nov 22, 2024
@AmirSa12 AmirSa12 changed the title feat: --packageManager feat: --packageManager=XYZ Nov 22, 2024
Copy link
Member

@Aslemammad Aslemammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, i think at this point we have to remove the detect package manager stuff!

@Aslemammad
Copy link
Member

Oh i see it's already done! thank you so much.

ok, let's add a slight documentation and ship this thing.

@AmirSa12 AmirSa12 requested a review from Aslemammad November 23, 2024 10:02
@Aslemammad
Copy link
Member

why there are changes related to the previous pr? maybe you should rebase first!

@Aslemammad
Copy link
Member

still, i think there should be a rebase. there are unrelated changes here.

Copy link
Member

@Aslemammad Aslemammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aslemammad Aslemammad merged commit a37c627 into main Nov 23, 2024
5 checks passed
@Aslemammad Aslemammad deleted the feat/package-manager branch November 23, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use npm in the bot comment by default

3 participants