Skip to content

Conversation

@Aslemammad
Copy link
Member

the hash function of ohash has a short length and hitting hash collisions was kinda inevitable!

so let's use proper keys from now on, for PRs, since they're long living, compared to workflow_run keys.

this would hopefully fix the element-plus issue we have.

@continuous-releases-staging
Copy link

continuous-releases-staging bot commented Dec 16, 2024

Open in Stackblitzexample-1example-2

npm i https://9749d680.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@308
npm i https://9749d680.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-a@308
npm i https://9749d680.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-b@308

commit: b9ecff1

@Aslemammad Aslemammad merged commit 1b3400f into main Dec 16, 2024
5 of 6 checks passed
@Aslemammad Aslemammad deleted the fix/avoid-pr-hash-collisions branch December 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants