fix: add typecheck script to backend #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great work! Everything looks good to me. |
Contributor
Author
|
i've added it but lets get #314 merged first so the |
Contributor
Author
|
it won't pass for now since |
AmirSa12
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I was trying to get tests running locally for 👀
getBindingdidn't exist and wasn't imported from anywhere. so i'm not sure about that one. is it made available globally by one of the runtimes? or did that code just not get hit in a long time and it hasn't been working for a while?i pulled in the
getR2Bindingfrom unstorage which seems to achieve the same, but that could be wrong and i'm just misunderstanding something